Sketch of datatree.inherit method #9065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
the
topic-DataTree
for more information, see https://pre-commit.ci
TomNicholas
commented
Jun 4, 2024
Comment on lines
+990
to
+995
| return merge_core( | ||
| [existing_variables, candidate_variables], | ||
| priority_arg=1, | ||
| explicit_coords=list(candidate_variables.keys()) | ||
| combine_attrs="override", | ||
| ) |
There was a problem hiding this comment.
This should just be align like in #9056
TomNicholas
commented
Jun 4, 2024
| # TODO should we be keeping track of which variables were coordinates? | ||
| all_inherited_variables.update(**inheritable_variables) | ||
|
|
||
| return DataTree.copy().update(all_inherited_variables) |
There was a problem hiding this comment.
This is one possibility - this provides the user with a way to access inherited variables without enforcing that constraint on all trees.
|
Closing as a WIP attempt to implement something we decided against in #9077 (i.e. we decided not to allow child nodes to have variables which don't align with parents). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is just pseudocode that I'm showing to compare against #9063)
whats-new.rstapi.rst